Kubernetes AdvancedNetworking: Added validation for pod_cidr when network_plugin is set to 'azure'. #1763
Conversation
lfshr
changed the title
| podCidr := profile["pod_cidr"].(string) | ||
|
|
||
| if networkPlugin == "azure" && podCidr != "" { | ||
| return fmt.Errorf("`network_profile.pod_cidr` can not be used when `network_profile.network_plugin` is set to `azure`. Please remove `network_profile.pod_cidr` or set `network_profile.network_plugin` to `kubenet`.") |
There was a problem hiding this comment.
🤔 since this is a list containing a single item, would this be clearer by either making:
network_profile.pod_cidr -> network_profile.0.pod_cidr
network_profile.network_plugin -> network_profile.0.network_plugin
or by updating this to:
the `pod_cidr` field in the `network_profile` block can not be specified when `network_plugin` is set to `azure`. Please remove `pod_cidr` or set `network_plugin` to `kubenet`.
There was a problem hiding this comment.
Hmm, I don't know about adding the index (mostly because when creating the terraform you don't really worry about the fact that it's a list so it makes it a little unclear)
I prefer your second option over all three. Thanks Tom!
|
Thanks! |
|
hey @lfshr @yves-vogl Just to let you know that we've just shipped support for this as a part of v1.13.0 of the AzureRM Provider :) Thanks! |
|
Seems like there might be a bug in the validation. The validation fails when changing the The work around is to destroy the I can provide a Terraform plan to recreate the issue if needed. |
|
@pedrohdz could you open up another issue and I'll take a look in a few days? I'm currently confined to bed rest 😞 |
CustomizeDiff's is more designed for changing the Plan rather than validation (so we're stepping around the edges of it's intended scope) - so it could be worth reverting this and instead document this instead?
Due to the way Terraform and the Provider plugin works this is hard (since this is across process boundaries), but you should be able to debug Acceptance Tests using something like Goland if you can write one to match this? @pedrohdz thanks for opening #1783 :) Thanks! |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
ghost
locked and limited conversation to collaborators
Kubernetes AdvancedNetworking: Added validation for pod_cidr when network_profile is set to 'azure'.
This fixes #1723